Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sentry Create Deploy Action #83

Merged
merged 14 commits into from Jun 10, 2021

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Jun 2, 2021

Overview

  • Introduce sentry_create_deploy action.
  • The url parameter of the sentry-cli command is named deploy_url in the action, as it collides with another param.

Testing

  • Created rspec tests similar to other actions, mainly testing the parameters and how they translate to sentry-cli parameters.
  • Tested with an iOS application that has sentry setup and created deploys with the param combinations. Could not see more info for deploys in senty.io though, is this a permissions/account "issue"?

Bildschirmfoto 2021-06-02 um 15 49 57

Relates to #82

@denrase denrase marked this pull request as ready for review June 2, 2021 14:07
@philipphofmann philipphofmann linked an issue Jun 2, 2021 that may be closed by this pull request
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd trust @philipphofmann and/or @HazAT's review but just some suggestions from my end:

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this. I added a few comments.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
lib/fastlane/plugin/sentry/actions/sentry_create_deploy.rb Outdated Show resolved Hide resolved
@denrase
Copy link
Collaborator Author

denrase commented Jun 5, 2021

@philipphofmann @bruno-garcia Thank you for your feedback, i have incorporated everything. Also, i have noticed that tests are failing for the upload action when i run them locally, which should not have been affected by this PR. Is this something known?

Fastlane
  Fastlane::FastFile
    upload dsym
      fails with API key and auth token
      fails with invalid dsym path
      should add bcsymbols to sentry-cli call (FAILED - 2)
      multiple dsym paths (FAILED - 3)
      Info.plist should exist (FAILED - 4)

@denrase
Copy link
Collaborator Author

denrase commented Jun 5, 2021

Also:

FastlaneCore::Helper::SentryConfig
  fallback .sentryclirc
    auth failing calling sentry-cli info (FAILED - 1)

README.md Show resolved Hide resolved
@philipphofmann
Copy link
Member

@philipphofmann @bruno-garcia Thank you for your feedback, i have incorporated everything. Also, i have noticed that tests are failing for the upload action when i run them locally, which should not have been affected by this PR. Is this something known?

Fastlane
  Fastlane::FastFile
    upload dsym
      fails with API key and auth token
      fails with invalid dsym path
      should add bcsymbols to sentry-cli call (FAILED - 2)
      multiple dsym paths (FAILED - 3)
      Info.plist should exist (FAILED - 4)

No this should be fixed. Do you maybe have time to open up another PR to fix these broken tests?

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Copy link

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks @denrase you may add Ruby to your CV :D

@denrase
Copy link
Collaborator Author

denrase commented Jun 8, 2021

@marandaneto Did collect all Pokémon as a kid, only natural to continue with programming languages in adulthood. ^^

@denrase
Copy link
Collaborator Author

denrase commented Jun 8, 2021

@philipphofmann

No this should be fixed. Do you maybe have time to open up another PR to fix these broken tests?

Will look into it!

@philipphofmann philipphofmann changed the title feat: Sentry Deploy Action feat: Sentry Create Deploy Action Jun 10, 2021
@philipphofmann philipphofmann merged commit 011b2ea into getsentry:master Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for creating deploys within release management
4 participants