Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Require github.com/ugorji/go@v1.1.7 #110

Merged
merged 2 commits into from Dec 11, 2019

Conversation

rhcarvalho
Copy link
Contributor

Require github.com/ugorji/go@v1.1.7 or later.

This is a dependency coming from github.com/gin-gonic/gin that had a
problem with conflicting multiple Go modules in a single Git repository.

Version 1.1.7 fixed the issue. The latest version
github.com/gin-gonic/gin@v1.5.0 requires github.com/ugorji/go@v1.1.7.

Since gin@v1.5.0 also introduces a breaking change, we can help our
users without requiring them to move on to gin@v1.5.0 right now.

Fixes #87

Require github.com/ugorji/go@v1.1.7 or later.

This is a dependency coming from github.com/gin-gonic/gin that had a
problem with conflicting multiple Go modules in a single Git repository.

Version 1.1.7 fixed the issue. The latest version
github.com/gin-gonic/gin@v1.5.0 requires github.com/ugorji/go@v1.1.7.

Since gin@v1.5.0 also introduces a breaking change, we can help our
users without requiring them to move on to gin@v1.5.0 right now.
@rhcarvalho rhcarvalho added this to In progress in Sentry SDK for Go via automation Dec 5, 2019
@rhcarvalho rhcarvalho moved this from In progress to Review in progress in Sentry SDK for Go Dec 10, 2019
Sentry SDK for Go automation moved this from Review in progress to Reviewer approved Dec 11, 2019
@rhcarvalho rhcarvalho merged commit 7a4af2e into getsentry:master Dec 11, 2019
Sentry SDK for Go automation moved this from Reviewer approved to Done Dec 11, 2019
@rhcarvalho rhcarvalho deleted the bump-indirect-dep branch December 11, 2019 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Dependencies conflict while updates the sentry version to 0.3.1
2 participants