Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(am): Add data field to Span interface #254

Merged
merged 2 commits into from
Jun 24, 2020
Merged

feat(am): Add data field to Span interface #254

merged 2 commits into from
Jun 24, 2020

Conversation

AbhiPrasad
Copy link
Member

Data is a valid field as part of the span interface, we should be including it.

https://develop.sentry.dev/sdk/event-payloads/span/

rhcarvalho
rhcarvalho suggested changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AbhiPrasad! Looks good, just one change required.

interfaces.go Outdated Show resolved Hide resolved
@AbhiPrasad AbhiPrasad merged commit 42815ba into master Jun 24, 2020
@AbhiPrasad AbhiPrasad deleted the abhi/feat/span-data branch June 24, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhcarvalho rhcarvalho rhcarvalho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AbhiPrasad @rhcarvalho