Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update attributions for vendored "baggage" #614

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

tonyo
Copy link
Member

@tonyo tonyo commented Mar 30, 2023

"internal/otel/baggage" package was initially vendored from opentelemetry-go, and then later we made some updates to it. According to our new attribution policy, adding some links to the original files (copyright notes are already there).

Ref getsentry/team-webplatform-meta#42, getsentry/team-ospo#120

AFAIK this is the only place where we need to attribute 3rd party code.

"internal/otel/baggage" package was initially vendored from
opentelemetry-go, and then later we made some updates to it.
According to our new attribution policy, adding some links to the
original files.

Ref getsentry/team-webplatform-meta#42, getsentry/team-ospo#120
@tonyo tonyo requested a review from cleptric March 30, 2023 10:48
@tonyo
Copy link
Member Author

tonyo commented Mar 30, 2023

cc @chadwhitacre

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fa1d04f) 79.84% compared to head (6666235) 79.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #614   +/-   ##
=======================================
  Coverage   79.84%   79.84%           
=======================================
  Files          38       38           
  Lines        3861     3861           
=======================================
  Hits         3083     3083           
  Misses        671      671           
  Partials      107      107           
Impacted Files Coverage Δ
internal/otel/baggage/baggage.go 97.54% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tonyo tonyo merged commit 231d5f0 into master Mar 31, 2023
@tonyo tonyo deleted the tonyo/ref-otel-baggage-attrib branch March 31, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants