Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase flush timeout in TestHTTPTransport #663

Merged
merged 1 commit into from Jul 5, 2023

Conversation

tonyo
Copy link
Member

@tonyo tonyo commented Jul 5, 2023

This test got increasingly flake lately, specifically on Windows. Let's see if it makes things better.

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06 🎉

Comparison is base (2563bd8) 80.61% compared to head (41d616b) 80.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
+ Coverage   80.61%   80.68%   +0.06%     
==========================================
  Files          43       43              
  Lines        4338     4338              
==========================================
+ Hits         3497     3500       +3     
+ Misses        714      712       -2     
+ Partials      127      126       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tonyo tonyo requested a review from cleptric July 5, 2023 10:37
@tonyo tonyo merged commit 1b2ac13 into master Jul 5, 2023
14 checks passed
@tonyo tonyo deleted the tonyo/feat-increase-flush-timeout-test branch July 5, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants