Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize http.response.status_code #811

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

ribice
Copy link
Collaborator

@ribice ribice commented Apr 7, 2024

This PR adds:

http method/response code to Echo and net/http
http response code to fasthttp and gin

Adds transaction tests for net/http

Once other integrations are covered in #809, #808 and #807 - all of them should have http.response.status_code which I would assume would resolve #667 .

@ribice ribice requested a review from cleptric April 7, 2024 09:13
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.09%. Comparing base (9311a06) to head (96cb304).

Files Patch % Lines
http/sentryhttp.go 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #811      +/-   ##
==========================================
+ Coverage   81.08%   81.09%   +0.01%     
==========================================
  Files          49       49              
  Lines        4087     4100      +13     
==========================================
+ Hits         3314     3325      +11     
- Misses        632      634       +2     
  Partials      141      141              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cleptric cleptric merged commit df20ce6 into master Apr 11, 2024
20 checks passed
@cleptric cleptric deleted the normalize-http-status-code branch April 11, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalize http.response.status_code for Metrics & Alerts
2 participants