Add breaking change note about Timber.tag

getsentry · Feb 8, 2022 · 2df5bb6 · 2df5bb6
1 parent fed2412
commit 2df5bb6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,10 @@
 
 * Fix: Do not include stacktrace frames into Timber message (#1898)
 
+Breaking changes:
+`Timber.tag` is no longer supported by our [Timber integration](https://docs.sentry.io/platforms/android/configuration/integrations/timber/) and will not appear on Sentry for error events. 
+Please vote on this [issue](https://github.com/getsentry/sentry-java/issues/1900), if you'd like us to provide support for that.
+
 ## 5.6.1
 
 * Fix: NPE while adding "response_body_size" breadcrumb, when response body is null (#1884)

diff --git a/sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberTree.kt b/sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberTree.kt
@@ -199,8 +199,8 @@ class SentryTimberTree(
         val level = getSentryLevel(priority)
         val sentryMessage = Message().apply {
             this.message = message
-            if (message != null && args.isNotEmpty()) {
-                this.formatted = message.format(*args)
+            if (!message.isNullOrEmpty() && args.isNotEmpty()) {
+                this.formatted = message?.format(*args)
             }
             this.params = args.map { it.toString() }
         }