Skip to content

Commit

Permalink
Merge 83f7838 into 7ca9895
Browse files Browse the repository at this point in the history
  • Loading branch information
markushi committed Oct 19, 2023
2 parents 7ca9895 + 83f7838 commit f9cd2b8
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 0 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

### Features

- Tag all spans with main thread flag ([#2998](https://github.com/getsentry/sentry-java/pull/2998))

## 6.32.0

### Features
Expand Down
3 changes: 3 additions & 0 deletions sentry/src/main/java/io/sentry/SentryTracer.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import io.sentry.protocol.TransactionNameSource;
import io.sentry.protocol.User;
import io.sentry.util.Objects;
import io.sentry.util.thread.MainThreadChecker;
import java.util.ArrayList;
import java.util.List;
import java.util.ListIterator;
Expand Down Expand Up @@ -384,6 +385,8 @@ private ISpan createChild(
}
});
span.setDescription(description);
span.setData(
SpanDataConvention.BLOCKED_MAIN_THREAD_KEY, MainThreadChecker.getInstance().isMainThread());
this.children.add(span);
return span;
}
Expand Down
6 changes: 6 additions & 0 deletions sentry/src/test/java/io/sentry/SentryTracerTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -1236,4 +1236,10 @@ class SentryTracerTest {
assertTrue(tracer.isFinished)
verify(fixture.hub).captureTransaction(any(), anyOrNull(), anyOrNull(), anyOrNull())
}

@Test
fun `when a span is launched, the main thread flag is set as span data`() {
val tracer = fixture.getSut()
assertNotNull(tracer.startChild("span.op").getData(SpanDataConvention.BLOCKED_MAIN_THREAD_KEY))
}
}

0 comments on commit f9cd2b8

Please sign in to comment.