Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include thread information for FileObserver captures #1473

Closed
marandaneto opened this issue Apr 13, 2021 · 1 comment · Fixed by #1501
Closed

Don't include thread information for FileObserver captures #1473

marandaneto opened this issue Apr 13, 2021 · 1 comment · Fixed by #1501

Comments

@marandaneto
Copy link
Contributor

Similar to https://github.com/getsentry/sentry-dart/blob/main/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt#L207-L216

If there's a captured message from the JS layer, the Android SDK sets the current thread if there's not an exception, but because of the file transport, the thread is always the file observer and this is just noisy/not useful.

@bruno-garcia bruno-garcia transferred this issue from getsentry/sentry-react-native May 12, 2021
@bruno-garcia bruno-garcia changed the title Clear Android thread list if not an Android/Native event Don't include thread information for FileObserver captures May 12, 2021
@bruno-garcia
Copy link
Member

We agreed to simply use hints to avoid attaching thread information from FileObserver captures (sentry-native, sentry-react-native, sentry-flutter events)

@bruno-garcia bruno-garcia moved this from Needs Discussion to Backlog in Mobile Platform Team Archived May 12, 2021
@marandaneto marandaneto added this to To do in kanban via automation May 27, 2021
@marandaneto marandaneto moved this from To do to Review in progress in kanban May 31, 2021
kanban automation moved this from Review in progress to Done May 31, 2021
Mobile Platform Team Archived automation moved this from Backlog to Done May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants