Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not append threads that come from the EnvelopeFileObserver #1501

Merged
merged 3 commits into from May 31, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented May 31, 2021

馃摐 Description

Fix: Do not append threads that come from the EnvelopeFileObserver

馃挕 Motivation and Context

Fix #1473

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2021

Codecov Report

Merging #1501 (63bf9cd) into main (dbc59e2) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1501      +/-   ##
============================================
+ Coverage     76.00%   76.03%   +0.03%     
- Complexity     1924     1926       +2     
============================================
  Files           191      191              
  Lines          6664     6665       +1     
  Branches        663      663              
============================================
+ Hits           5065     5068       +3     
+ Misses         1274     1273       -1     
+ Partials        325      324       -1     
Impacted Files Coverage 螖
...ry/src/main/java/io/sentry/MainEventProcessor.java 83.33% <66.66%> (+0.16%) 猬嗭笍
...n/java/io/sentry/transport/ReusableCountLatch.java 94.11% <0.00%> (+5.88%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update dbc59e2...63bf9cd. Read the comment docs.

@marandaneto marandaneto merged commit fd64cc0 into main May 31, 2021
@marandaneto marandaneto deleted the fix/threads-fileobserver branch May 31, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't include thread information for FileObserver captures
3 participants