Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"java.util.logging.LogManager is a restricted class" on AppEngine #228

Closed
bretthoerner opened this issue Jul 15, 2016 · 4 comments
Closed
Assignees

Comments

@bretthoerner
Copy link

I'm not sure how Sentry could be working on AppEngine for anyone given a glance at the code.

Details here: #122 (comment)

@bretthoerner bretthoerner self-assigned this Jul 15, 2016
@wholegroup
Copy link

@bretthoerner

  1. You should load properties direct from file (see sources of https://java.net/projects/javamail/sources/mercurial/content/mail/src/main/java/com/sun/mail/util/logging/LogManagerProperties.java loadLogManager/readConfiguration)

  2. Also you can't call methods of parent Handler class if they call checkPermission() (for example this.setFilter(new SentryHandler.DropRavenFilter());). You should use this filter in isLoggable method.

  3. on GAE you can't set custom handlers in logging.properties file. To enable a custom log handler I do: Logger.getLogger("").addHandler(new SentryHandler());

Probably it's better to create new handler like AppengineSentryHandler

p.s. Pls have a look at http://pastebin.com/Cy3AC8Wn (this handler works well on GAE now)

@bretthoerner
Copy link
Author

@wholegroup Thanks so much, that was very helpful. Do you mind taking a glance at #282 ? I'd live your opinion.

@bruno-garcia
Copy link
Member

#282 wasn't merged. Reopening.

@marandaneto
Copy link
Contributor

Sentry-Java SDK v3 deprecated AppEngine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants