Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename reportFullDisplayed to reportFullyDisplayed #2575

Closed
philipphofmann opened this issue Feb 28, 2023 · 1 comment · Fixed by #2585
Closed

Rename reportFullDisplayed to reportFullyDisplayed #2575

philipphofmann opened this issue Feb 28, 2023 · 1 comment · Fixed by #2585
Assignees
@stefanosiano
Labels
Platform: Android
Milestone
7.0.0

Comments

@philipphofmann
Copy link
Member

philipphofmann commented Feb 28, 2023 •
edited

Description

Rename reportFullDisplayed to reportFullyDisplayed, as report full displayed is not proper English. Please also update the docs accordingly.
@philipphofmann philipphofmann added this to the 7.0.0 milestone Feb 28, 2023
@philipphofmann philipphofmann mentioned this issue Feb 28, 2023
Merged
7 tasks
@markushi
Copy link
Member

markushi commented Mar 1, 2023

Let's @Deprecate the existing method and introduce the new one

@stefanosiano stefanosiano mentioned this issue Mar 3, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanosiano stefanosiano

Labels
Platform: Android
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Renamed reportFullDisplayed to reportFullyDisplayed getsentry/sentry-java
4 participants
@markushi @philipphofmann @adinauer @stefanosiano