Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed reportFullDisplayed to reportFullyDisplayed #2585

Merged
merged 5 commits into from
Mar 6, 2023

Conversation

stefanosiano
Copy link
Member

@stefanosiano stefanosiano commented Mar 3, 2023

📜 Description

Rename all occurrences of FullDisplayed with FullyDisplayed
Deprecated old Sentry.reportFullDisplayed() method

💡 Motivation and Context

reportFullDisplayed is not correct english
It fixes #2575

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

deprecated old Sentry.reportFullDisplayed() method
deprecated old Sentry.reportFullDisplayed() method
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 337.86 ms 384.62 ms 46.76 ms
Size 1.73 MiB 2.34 MiB 626.25 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7c199d8 323.18 ms 391.33 ms 68.15 ms

App size

Revision Plain With Sentry Diff
7c199d8 1.73 MiB 2.34 MiB 626.23 KiB

Previous results on branch: fix/rename-full-displayed

Startup times

Revision Plain With Sentry Diff
9129a4b 318.52 ms 355.42 ms 36.90 ms
d20ef6a 354.69 ms 421.38 ms 66.69 ms
7ad99f4 350.50 ms 405.67 ms 55.17 ms
32b5573 323.83 ms 340.88 ms 17.05 ms

App size

Revision Plain With Sentry Diff
9129a4b 1.73 MiB 2.34 MiB 626.25 KiB
d20ef6a 1.73 MiB 2.34 MiB 626.25 KiB
7ad99f4 1.73 MiB 2.34 MiB 626.25 KiB
32b5573 1.73 MiB 2.34 MiB 626.25 KiB

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage: 93.33% and project coverage change: +0.04 🎉

Comparison is base (4eb4794) 80.42% compared to head (eafa18c) 80.47%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2585      +/-   ##
============================================
+ Coverage     80.42%   80.47%   +0.04%     
- Complexity     4027     4032       +5     
============================================
  Files           333      333              
  Lines         15189    15193       +4     
  Branches       1979     1979              
============================================
+ Hits          12216    12226      +10     
+ Misses         2194     2188       -6     
  Partials        779      779              
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/HubAdapter.java 9.23% <0.00%> (+3.07%) ⬆️
...rc/main/java/io/sentry/FullyDisplayedReporter.java 100.00% <100.00%> (ø)
sentry/src/main/java/io/sentry/Hub.java 76.99% <100.00%> (ø)
sentry/src/main/java/io/sentry/IHub.java 92.59% <100.00%> (+0.59%) ⬆️
sentry/src/main/java/io/sentry/NoOpHub.java 47.72% <100.00%> (ø)
sentry/src/main/java/io/sentry/Sentry.java 60.30% <100.00%> (+2.49%) ⬆️
sentry/src/main/java/io/sentry/SentryOptions.java 80.43% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename reportFullDisplayed to reportFullyDisplayed
3 participants