-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Deserialization #1047
Refactor Deserialization #1047
Conversation
looks good, missing changelog though. |
Codecov Report
@@ Coverage Diff @@
## main #1047 +/- ##
============================================
+ Coverage 72.95% 72.97% +0.01%
+ Complexity 1523 1520 -3
============================================
Files 161 161
Lines 5465 5457 -8
Branches 549 549
============================================
- Hits 3987 3982 -5
+ Misses 1189 1186 -3
Partials 289 289
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bruno-garcia perhaps you can also take a look at this one since @marandaneto asked to make it a part of the Performance PR too. |
85ef5da
to
be6042d
Compare
馃摙 Type of change
馃摐 Description
Use single method to deserialize JSON.
馃挕 Motivation and Context
#971 (comment)
馃挌 How did you test it?
Unit tests.
馃摑 Checklist