Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Deserialization #1047

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Refactor Deserialization #1047

merged 1 commit into from
Nov 21, 2020

Conversation

maciejwalkowiak
Copy link
Contributor

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

Use single method to deserialize JSON.

馃挕 Motivation and Context

#971 (comment)

馃挌 How did you test it?

Unit tests.

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

@marandaneto
Copy link
Contributor

looks good, missing changelog though.

@codecov-io
Copy link

codecov-io commented Nov 16, 2020

Codecov Report

Merging #1047 (be6042d) into main (3c87a48) will increase coverage by 0.01%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1047      +/-   ##
============================================
+ Coverage     72.95%   72.97%   +0.01%     
+ Complexity     1523     1520       -3     
============================================
  Files           161      161              
  Lines          5465     5457       -8     
  Branches        549      549              
============================================
- Hits           3987     3982       -5     
+ Misses         1189     1186       -3     
  Partials        289      289              
Impacted Files Coverage 螖 Complexity 螖
sentry/src/main/java/io/sentry/NoOpSerializer.java 57.14% <酶> (+17.14%) 4.00 <0.00> (酶)
...ry/src/main/java/io/sentry/SentryEnvelopeItem.java 83.87% <50.00%> (酶) 16.00 <0.00> (酶)
sentry/src/main/java/io/sentry/GsonSerializer.java 96.82% <100.00%> (-0.24%) 10.00 <0.00> (-3.00)
sentry/src/main/java/io/sentry/OutboxSender.java 66.21% <100.00%> (酶) 14.00 <0.00> (酶)
...y/src/main/java/io/sentry/cache/CacheStrategy.java 49.61% <100.00%> (酶) 20.00 <0.00> (酶)
...y/src/main/java/io/sentry/cache/EnvelopeCache.java 49.09% <100.00%> (酶) 17.00 <0.00> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3c87a48...be6042d. Read the comment docs.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciejwalkowiak
Copy link
Contributor Author

@bruno-garcia perhaps you can also take a look at this one since @marandaneto asked to make it a part of the Performance PR too.

Base automatically changed from performance to main November 20, 2020 22:48
@bruno-garcia bruno-garcia merged commit 4ae6292 into main Nov 21, 2020
@bruno-garcia bruno-garcia deleted the performance-deserialize branch November 21, 2020 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants