Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring: set transaction name on events also when performance feature is not active #1067

Merged
merged 3 commits into from
Nov 26, 2020

Conversation

maciejwalkowiak
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Spring: set transaction name on events also when performance feature is not active

💡 Motivation and Context

Follow-up to #513 compatible with SDK 3.x and the way we resolve transaction names in the performance feature.

💚 How did you test it?

Unit & Integration tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov-io
Copy link

Codecov Report

Merging #1067 (478a5ff) into main (c327574) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1067      +/-   ##
============================================
+ Coverage     72.95%   73.01%   +0.05%     
- Complexity     1520     1522       +2     
============================================
  Files           161      161              
  Lines          5461     5462       +1     
  Branches        550      551       +1     
============================================
+ Hits           3984     3988       +4     
+ Misses         1187     1185       -2     
+ Partials        290      289       -1     
Impacted Files Coverage Δ Complexity Δ
...java/io/sentry/spring/SentryExceptionResolver.java 76.00% <ø> (+1.92%) 5.00 <0.00> (ø)
...ring/SentryRequestHttpServletRequestProcessor.java 100.00% <100.00%> (ø) 3.00 <1.00> (+1.00)
...sentry/spring/tracing/TransactionNameProvider.java 100.00% <0.00%> (+33.33%) 3.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c327574...478a5ff. Read the comment docs.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciejwalkowiak maciejwalkowiak merged commit 8160083 into main Nov 26, 2020
@maciejwalkowiak maciejwalkowiak deleted the gh-513 branch November 26, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants