fix: Remove method reference in SentryEnvelopeItem #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method reference in SentryEnvelopeItem could cause problems on Android. This is fixed with replacing it with a lambda.
philipphofmann
requested review from
bruno-garcia,
maciejwalkowiak and
marandaneto
as code owners
8 tasks
marandaneto
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摙 Type of change
馃摐 Description
The method reference in SentryEnvelopeItem could cause problems on Android. This is fixed with
replacing it with a lambda.
馃挕 Motivation and Context
https://github.com/getsentry/sentry-java/pull/1082/files#r535113142
馃挌 How did you test it?
CI.
馃摑 Checklist
馃敭 Next steps