Fix: Sort breadcrumbs by Date if the event has breadcrumbs #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
requested review from
bruno-garcia and
maciejwalkowiak
as code owners
marandaneto
changed the title
bruno-garcia
approved these changes
Dec 4, 2020
marandaneto
commented
Dec 4, 2020
maciejwalkowiak
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摙 Type of change
馃摐 Description
Fix: Sort breadcrumbs by Date if the event has breadcrumbs
馃挕 Motivation and Context
If an event captured on a top SDK like Flutter and later sent by the Android SDK, the Scope breadcrumbs are merged along with the breadcrumbs from the event, but it's not respecting the timeline.
Ideally, this would be solved by the Scope sync, but if the Scope sync. can be opt-out, the same problem would happen.
馃挌 How did you test it?
馃摑 Checklist
馃敭 Next steps