Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Set release and environment on Transactions. #1152

Merged
merged 3 commits into from
Jan 7, 2021
Merged

Conversation

maciejwalkowiak
Copy link
Contributor

馃摐 Description

Set release and environment on Transactions.

馃挕 Motivation and Context

Fixes #1147

Both release and environment have to be set on transactions independently from how they are set on SentryEvents since transactions are not a subject of event processing.

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

@codecov-io
Copy link

Codecov Report

Merging #1152 (df70675) into main (bcaf6e3) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1152      +/-   ##
============================================
+ Coverage     75.22%   75.25%   +0.02%     
- Complexity     1630     1633       +3     
============================================
  Files           168      168              
  Lines          5639     5645       +6     
  Branches        554      555       +1     
============================================
+ Hits           4242     4248       +6     
  Misses         1144     1144              
  Partials        253      253              
Impacted Files Coverage 螖 Complexity 螖
sentry/src/main/java/io/sentry/SentryEvent.java 69.07% <酶> (-1.81%) 43.00 <0.00> (-4.00)
...entry/src/main/java/io/sentry/SentryBaseEvent.java 92.30% <100.00%> (+1.39%) 22.00 <4.00> (+4.00)
sentry/src/main/java/io/sentry/SentryClient.java 87.78% <100.00%> (+0.28%) 71.00 <3.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update bcaf6e3...df70675. Read the comment docs.

@maciejwalkowiak maciejwalkowiak merged commit 5532f73 into main Jan 7, 2021
@maciejwalkowiak maciejwalkowiak deleted the gh-1147 branch January 7, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

environment and other fields are missing for transactions
3 participants