Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: OutboxSender supports all envelope item types #1158

Merged
merged 7 commits into from
Jan 14, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jan 12, 2021

馃摐 Description

Feat: OutboxSender supports all envelope item types

馃挕 Motivation and Context

#1157 and #1103

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

馃敭 Next steps

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, just needing tests or there's something else?

@marandaneto
Copy link
Contributor Author

LGTM so far, just needing tests or there's something else?

runtime tests and unit tests, but looks straightforward, will finish today

@codecov-io
Copy link

Codecov Report

Merging #1158 (15856bb) into main (8159439) will decrease coverage by 0.03%.
The diff coverage is 70.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1158      +/-   ##
============================================
- Coverage     75.25%   75.22%   -0.04%     
- Complexity     1661     1663       +2     
============================================
  Files           173      173              
  Lines          5808     5820      +12     
  Branches        568      569       +1     
============================================
+ Hits           4371     4378       +7     
- Misses         1173     1177       +4     
- Partials        264      265       +1     
Impacted Files Coverage 螖 Complexity 螖
sentry/src/main/java/io/sentry/OutboxSender.java 65.11% <70.00%> (-1.10%) 16.00 <2.00> (+2.00) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 8159439...15856bb. Read the comment docs.

@marandaneto marandaneto marked this pull request as ready for review January 13, 2021 13:56
@marandaneto marandaneto requested a review from a team January 13, 2021 14:25
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marandaneto marandaneto merged commit a385352 into main Jan 14, 2021
@marandaneto marandaneto deleted the feat/support-envelope-types branch January 14, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants