Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenient method for accessing event's throwable. #1202

Merged
merged 4 commits into from
Jan 22, 2021
Merged

Conversation

maciejwalkowiak
Copy link
Contributor

馃摐 Description

Add convenient method for accessing event's throwable.

馃挕 Motivation and Context

Fixes #1201

馃挌 How did you test it?

Unit tests.

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • No breaking changes

@codecov-io
Copy link

codecov-io commented Jan 22, 2021

Codecov Report

Merging #1202 (cd77169) into main (b668630) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1202      +/-   ##
============================================
+ Coverage     74.58%   74.64%   +0.05%     
- Complexity     1676     1680       +4     
============================================
  Files           176      176              
  Lines          5898     5904       +6     
  Branches        574      575       +1     
============================================
+ Hits           4399     4407       +8     
+ Misses         1235     1233       -2     
  Partials        264      264              
Impacted Files Coverage 螖 Complexity 螖
sentry/src/main/java/io/sentry/Sentry.java 42.74% <100.00%> (+0.88%) 18.00 <1.00> (+1.00)
...entry/src/main/java/io/sentry/SentryBaseEvent.java 88.09% <100.00%> (+1.25%) 22.00 <2.00> (+2.00)
sentry/src/main/java/io/sentry/SentryEvent.java 70.83% <0.00%> (+2.08%) 44.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update d6c2ede...cd77169. Read the comment docs.

*
* @return the Throwable or null
*/
public @Nullable Throwable getOriginThrowable() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could remove the code dup from DuplicateEventDetectionEventProcessor using this method now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True! Will be removed in few mins.

@maciejwalkowiak maciejwalkowiak merged commit 3eaa67f into main Jan 22, 2021
@maciejwalkowiak maciejwalkowiak deleted the gh-1201 branch January 22, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal ExceptionMechanismException type in SentryEvent
3 participants