Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove misleading error logs #1222

Merged
merged 4 commits into from
Feb 4, 2021
Merged

Fix: Remove misleading error logs #1222

merged 4 commits into from
Feb 4, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

馃摐 Description

Fix: Remove misleading error logs

馃挕 Motivation and Context

Fixes #1221

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@maciejwalkowiak maciejwalkowiak merged commit 1431c5e into main Feb 4, 2021
@maciejwalkowiak maciejwalkowiak deleted the gh-1221 branch February 4, 2021 11:01
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logging 'Stack peek was null when {method}' is misleading for some Hub calls.
2 participants
@maciejwalkowiak @marandaneto