Add overloads for startTrasaction taking op and description. #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
marandaneto
approved these changes
Feb 10, 2021
|
lets wait for the discussion #1241 before merging |
see #1241 (comment) |
it's a breaking change, overloads don't take only a |
marandaneto
reviewed
Feb 16, 2021
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ | |||
| * Enchancement: Support @SentrySpan and @SentryTransaction on classes and interfaces. (#1243) | |||
| * Enchancement: Do not serialize empty collections and maps (#1245) | |||
| * Ref: Simplify RestTemplate instrumentation (#1246) | |||
| * Enchancement: Add overloads for startTrasaction taking op and description (#1244) | |||
There was a problem hiding this comment.
good to be under the new breaking change section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摐 Description
Add overloads for startTrasaction taking op and description.
馃挕 Motivation and Context
Fixes #1241.
馃挌 How did you test it?
Unit tests
馃摑 Checklist