Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify RestTemplate instrumentation. #1246

Merged
merged 2 commits into from
Feb 10, 2021
Merged

Simplify RestTemplate instrumentation. #1246

merged 2 commits into from
Feb 10, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

馃摐 Description

Instead of passing templated URL to span description, pass real URL against which request is executed. It adds more details about request to executed Span and simplifies RestTemplate instrumentation configuration in non-boot usage.

馃挕 Motivation and Context

Fixes #1240.

馃挌 How did you test it?

Unit & Integration tests.

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

Update reference docs.

Instead of passing templated URL to span description, pass real URL against which request is executed. It adds more details about request to executed Span and simplifies RestTemplate instrumentation configuration in non-boot usage.

Fixes #1240.
@marandaneto
Copy link
Contributor

@codecov-io
Copy link

Codecov Report

Merging #1246 (516634f) into main (4066bc6) will increase coverage by 0.14%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1246      +/-   ##
============================================
+ Coverage     74.68%   74.83%   +0.14%     
  Complexity     1720     1720              
============================================
  Files           180      180              
  Lines          6047     6031      -16     
  Branches        601      600       -1     
============================================
- Hits           4516     4513       -3     
+ Misses         1257     1244      -13     
  Partials        274      274              
Impacted Files Coverage 螖 Complexity 螖
.../spring/boot/SentrySpanRestTemplateCustomizer.java 100.00% <酶> (酶) 3.00 <0.00> (酶)
...racing/SentrySpanClientHttpRequestInterceptor.java 0.00% <0.00%> (酶) 0.00 <0.00> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 4066bc6...516634f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spans created by SentrySpanClientHttpRequestInterceptor only show request method
3 participants