Set SDK version on Transactions. #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
reviewed
Mar 10, 2021
| val transaction = SentryTransaction("name", "op") | ||
| val sdkVersion = SdkVersion("transaction.sdk.name", "version") | ||
| transaction.sdk = sdkVersion | ||
| transaction.environment = "transactionEnvironment" |
There was a problem hiding this comment.
Suggested change
| transaction.environment = "transactionEnvironment" |
marandaneto
reviewed
Mar 10, 2021
Comment on lines
849
to
858
| fixture.sentryOptions.sdkVersion = SdkVersion("sdk.name", "version") | ||
| val sut = fixture.getSut() | ||
| val transaction = SentryTransaction("name", "op") | ||
| sut.captureTransaction(transaction) | ||
| assertEquals(fixture.sentryOptions.sdkVersion, transaction.sdk) | ||
| } | ||
|
|
||
| @Test | ||
| fun `when transaction has SDK version set, and the SDK version is set on options, options values are not applied to transactions`() { | ||
| fixture.sentryOptions.sdkVersion = SdkVersion("sdk.name", "version") |
There was a problem hiding this comment.
could we set SdkVersion already in the creation of sentryOptions?
There was a problem hiding this comment.
Yep, I'll refactor this whole test class in subsequent PR.
marandaneto
approved these changes
Mar 10, 2021
Codecov Report
@@ Coverage Diff @@
## main #1314 +/- ##
============================================
+ Coverage 75.65% 75.85% +0.19%
- Complexity 1786 1798 +12
============================================
Files 183 183
Lines 6207 6229 +22
Branches 622 623 +1
============================================
+ Hits 4696 4725 +29
+ Misses 1232 1226 -6
+ Partials 279 278 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摐 Description
Set SDK version on Transactions.
馃挕 Motivation and Context
Fixes #1307
馃挌 How did you test it?
Unit tests.
馃摑 Checklist