Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not bind transactions to scope by default. #1376

Merged
merged 3 commits into from Apr 7, 2021
Merged

Do not bind transactions to scope by default. #1376

merged 3 commits into from Apr 7, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

馃摐 Description

Do not bind transactions to scope by default.

馃挕 Motivation and Context

Fixes #1355

馃挌 How did you test it?

Unit & Integration tests.

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review April 6, 2021 08:31
@marandaneto
Copy link
Contributor

@maciejwalkowiak ActivityLifecycleIntegration could be improved, bindToScope=false is not necessary anymore

marandaneto
marandaneto approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciejwalkowiak maciejwalkowiak merged commit 142dd44 into main Apr 7, 2021
@maciejwalkowiak maciejwalkowiak deleted the gh-1355 branch April 7, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bindToScope should be false by default
2 participants
@maciejwalkowiak @marandaneto