Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix Hub thread safety. #1388

Merged
merged 2 commits into from Apr 12, 2021
Merged

Fix: fix Hub thread safety. #1388

merged 2 commits into from Apr 12, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

馃摐 Description

Fix: fix Hub thread safety.

馃挕 Motivation and Context

WeakHashMap is not thread safe and must be synchronized.

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

`WeakHashMap` is not thread safe and must be synchronized.
@codecov-io
Copy link

codecov-io commented Apr 9, 2021

Codecov Report

Merging #1388 (6f816f9) into main (972a01b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1388   +/-   ##
=========================================
  Coverage     75.83%   75.83%           
  Complexity     1879     1879           
=========================================
  Files           190      190           
  Lines          6413     6414    +1     
  Branches        643      643           
=========================================
+ Hits           4863     4864    +1     
  Misses         1262     1262           
  Partials        288      288           
Impacted Files Coverage 螖 Complexity 螖
sentry/src/main/java/io/sentry/Hub.java 74.35% <100.00%> (+0.07%) 76.00 <1.00> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 972a01b...6f816f9. Read the comment docs.

@maciejwalkowiak maciejwalkowiak merged commit 19fb028 into main Apr 12, 2021
@maciejwalkowiak maciejwalkowiak deleted the fix-thread-safety branch April 12, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants