Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: set status and associate events with transactions #1426

Merged
merged 9 commits into from Apr 23, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Set status when exception is thrown during transaction execution, and associate exceptions with transactions.

💡 Motivation and Context

#1351

💚 How did you test it?

Unit & Integration tests

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review April 20, 2021 19:46
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2021

Codecov Report

Merging #1426 (341a4e1) into main (c37df94) will increase coverage by 0.04%.
The diff coverage is 85.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1426      +/-   ##
============================================
+ Coverage     75.80%   75.84%   +0.04%     
- Complexity     1866     1870       +4     
============================================
  Files           185      186       +1     
  Lines          6389     6405      +16     
  Branches        637      639       +2     
============================================
+ Hits           4843     4858      +15     
  Misses         1258     1258              
- Partials        288      289       +1     
Impacted Files Coverage Δ Complexity Δ
sentry/src/main/java/io/sentry/HubAdapter.java 5.26% <0.00%> (ø) 3.00 <0.00> (ø)
sentry/src/main/java/io/sentry/IHub.java 85.00% <ø> (ø) 13.00 <0.00> (ø)
sentry/src/main/java/io/sentry/Hub.java 74.35% <72.72%> (-0.29%) 77.00 <1.00> (ø)
...sentry/spring/tracing/SentryTransactionAdvice.java 82.35% <100.00%> (+3.78%) 6.00 <0.00> (ø)
sentry/src/main/java/io/sentry/NoOpHub.java 57.89% <100.00%> (ø) 21.00 <1.00> (ø)
sentry/src/main/java/io/sentry/Span.java 92.00% <100.00%> (ø) 24.00 <0.00> (ø)
sentry/src/main/java/io/sentry/util/Pair.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...y/spring/HttpServletRequestSentryUserProvider.java 100.00% <0.00%> (+5.55%) 8.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c37df94...341a4e1. Read the comment docs.

maciejwalkowiak and others added 3 commits April 21, 2021 10:53
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
CI isnt happy though

@maciejwalkowiak maciejwalkowiak merged commit 407f709 into main Apr 23, 2021
@maciejwalkowiak maciejwalkowiak deleted the gh-1351-transaction-advice branch April 23, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants