Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullability annotations to integrations modules #1462

Merged
merged 38 commits into from May 12, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak commented May 5, 2021

📜 Description

Add nullability annotations to integrations modules

💡 Motivation and Context

Continuation of #1439

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

#skip-changelog

@maciejwalkowiak
Copy link
Contributor Author

#skip-changelog

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2021

Codecov Report

Merging #1462 (b4870c4) into main (b45944c) will decrease coverage by 0.02%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1462      +/-   ##
============================================
- Coverage     75.64%   75.62%   -0.03%     
  Complexity     1908     1908              
============================================
  Files           190      190              
  Lines          6546     6551       +5     
  Branches        659      659              
============================================
+ Hits           4952     4954       +2     
- Misses         1279     1280       +1     
- Partials        315      317       +2     
Impacted Files Coverage Δ Complexity Δ
...src/main/java/io/sentry/log4j2/SentryAppender.java 84.81% <ø> (ø) 21.00 <0.00> (ø)
...a/io/sentry/spring/boot/InAppIncludesResolver.java 80.00% <ø> (ø) 4.00 <0.00> (ø)
...main/java/io/sentry/spring/SentryHubRegistrar.java 95.00% <ø> (ø) 7.00 <0.00> (ø)
.../io/sentry/spring/SentryInitBeanPostProcessor.java 97.22% <ø> (ø) 6.00 <0.00> (ø)
...rc/main/java/io/sentry/logback/SentryAppender.java 88.75% <50.00%> (-1.13%) 25.00 <1.00> (ø)
...c/main/java/io/sentry/spring/SentryUserFilter.java 93.33% <100.00%> (+0.47%) 10.00 <0.00> (ø)
...entry/spring/SentryUserProviderEventProcessor.java 96.77% <100.00%> (+0.22%) 12.00 <0.00> (ø)
...n/java/io/sentry/transport/ReusableCountLatch.java 88.23% <0.00%> (-5.89%) 8.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45944c...b4870c4. Read the comment docs.

Base automatically changed from nullability to main May 10, 2021 16:19
@marandaneto
Copy link
Contributor

@maciejwalkowiak can you fix the conflicts and merge main into this branch so we can review? thanks

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto
Copy link
Contributor

@maciejwalkowiak please have a look at getsentry/sentry-docs#3567 too

@maciejwalkowiak maciejwalkowiak merged commit 112c46d into main May 12, 2021
@maciejwalkowiak maciejwalkowiak deleted the nullability-logging branch May 12, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants