Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: NPE when adding Context Data with null values for log4j2 #1465

Merged
merged 3 commits into from May 7, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

馃摐 Description

Fix: Fix NPE when adding Context Data with null values for log4j2

馃挕 Motivation and Context

Fixes #1386

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code
  • [ x] I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2021

Codecov Report

Merging #1465 (d4a013b) into main (ada5080) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1465      +/-   ##
============================================
+ Coverage     75.83%   75.85%   +0.01%     
- Complexity     1901     1906       +5     
============================================
  Files           189      189              
  Lines          6502     6506       +4     
  Branches        640      642       +2     
============================================
+ Hits           4931     4935       +4     
  Misses         1275     1275              
  Partials        296      296              
Impacted Files Coverage 螖 Complexity 螖
...jul/src/main/java/io/sentry/jul/SentryHandler.java 74.59% <100.00%> (-0.41%) 34.00 <2.00> (酶)
...src/main/java/io/sentry/log4j2/SentryAppender.java 84.81% <100.00%> (+0.19%) 21.00 <2.00> (+2.00)
...rc/main/java/io/sentry/logback/SentryAppender.java 89.87% <100.00%> (-0.13%) 25.00 <2.00> (酶)
.../src/main/java/io/sentry/util/CollectionUtils.java 62.50% <100.00%> (+22.50%) 6.00 <3.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ada5080...d4a013b. Read the comment docs.

@marandaneto marandaneto changed the title Fix: Fix NPE when adding Context Data with null values for log4j2 Fix: NPE when adding Context Data with null values for log4j2 May 7, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciejwalkowiak maciejwalkowiak merged commit 5fa4b52 into main May 7, 2021
@maciejwalkowiak maciejwalkowiak deleted the gh-1386 branch May 7, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE when adding Context Data with null values for log4j2
3 participants