-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Sentry BOM #1486
Generate Sentry BOM #1486
Conversation
Since I am not sure how to release the BOM file, the |
Codecov Report
@@ Coverage Diff @@
## main #1486 +/- ##
=========================================
Coverage 75.93% 75.93%
Complexity 2004 2004
=========================================
Files 202 202
Lines 6943 6943
Branches 691 691
=========================================
Hits 5272 5272
Misses 1335 1335
Partials 336 336 Continue to review full report at Codecov.
|
I published it locally and tried using
the other thing is, |
just tried locally:
and it worked, thanks @maciejwalkowiak |
@maciejwalkowiak do you prefer opening a new PR for fixing the release script or this one? |
How the settings should be modified? |
ups sorry, |
@marandaneto updated the release script. Works well when I tested it locally. |
scripts/release.kts
Outdated
|
||
val file: String | ||
|
||
val androidFile = folder | ||
.listFiles { it -> it.name.contains("release") && it.extension == "aar" } | ||
.firstOrNull() | ||
|
||
if (androidFile != null) { | ||
file = androidFile.path | ||
val bomFile = folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iker-barriocanal these changes will need to be updated in the craft release too, right?
@marandaneto should we merge it or not yet? |
I will test later but also need to check out #1486 (comment) |
@iker-barriocanal I am about to merge this, is craft ready to do a |
scripts/release.kts
Outdated
val command = "./mvnw gpg:sign-and-deploy-file " + | ||
"-Dfile=$pomFile " + | ||
"-DpomFile=$pomFile " + | ||
"-DrepositoryId=$repositoryId " + | ||
"-Durl=$repositoryUrl " + | ||
"--settings $settingsPath" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iker-barriocanal how craft will handle this, as it's a different way of calling maven CLI for a bom (which is only a pom.xml) file?
An update, I merged the docs (getsentry/sentry-docs#3832) which I assume I'll need to revert. But to let y'all know we're just blocked on being able to release this. Hopefully @iker-barriocanal can help us out on this one too |
@bruno-garcia @marandaneto opened a PR to support this in Craft: getsentry/craft#270. |
And it's merged! thanks Iker, I guess we're close to merging this one then |
馃摐 Description
Generate Sentry BOM
馃挕 Motivation and Context
Fixes #1484
馃挌 How did you test it?
馃摑 Checklist
馃敭 Next steps
Update
release.kt
script BOM to publish to Maven central.