Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add secondary constructor to SentryOkHttpInterceptor #1491

Merged
merged 3 commits into from May 27, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

馃摐 Description

Add secondary constructor to SentryOkHttpInterceptor.

馃挕 Motivation and Context

Without secondary constructor it is inconvenient to pass beforeSpan in constructor without using named parameter or from Java.

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@codecov-commenter
Copy link

Codecov Report

Merging #1491 (2c76333) into main (730e7d5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1491   +/-   ##
=========================================
  Coverage     75.65%   75.66%           
  Complexity     1929     1929           
=========================================
  Files           191      191           
  Lines          6598     6600    +2     
  Branches        666      666           
=========================================
+ Hits           4992     4994    +2     
  Misses         1280     1280           
  Partials        326      326           
Impacted Files Coverage 螖
...src/main/java/io/sentry/log4j2/SentryAppender.java 85.18% <100.00%> (+0.37%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update d58fbdb...2c76333. Read the comment docs.

@marandaneto marandaneto merged commit 769ce4b into main May 27, 2021
@marandaneto marandaneto deleted the okhttp-constructor branch May 27, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants