Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref: Deprecate SentryBaseEvent#getOriginThrowable and add SentryBaseEvent#getThrowableMechanism #1502

Merged
merged 6 commits into from May 31, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented May 31, 2021

📜 Description

Ref: Deprecate SentryBaseEvent#getOriginThrowable and add SentryBaseEvent#getThrowableMechanism

💡 Motivation and Context

Fix #1301

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2021

Codecov Report

Merging #1502 (170d227) into main (fd64cc0) will increase coverage by 0.00%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1502   +/-   ##
=========================================
  Coverage     76.00%   76.01%           
- Complexity     1926     1927    +1     
=========================================
  Files           191      191           
  Lines          6665     6666    +1     
  Branches        663      663           
=========================================
+ Hits           5066     5067    +1     
  Misses         1274     1274           
  Partials        325      325           
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/SentryClient.java 87.22% <66.66%> (ø)
.../sentry/DuplicateEventDetectionEventProcessor.java 100.00% <100.00%> (ø)
...ry/src/main/java/io/sentry/MainEventProcessor.java 83.33% <100.00%> (ø)
...entry/src/main/java/io/sentry/SentryBaseEvent.java 81.81% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd64cc0...170d227. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit ad283c1 into main May 31, 2021
@marandaneto marandaneto deleted the ref/throwable-mechanism branch May 31, 2021 17:07
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.
`Instructions and example for changelog`$

Please add an entry to CHANGELOG.md` to the "Unreleased" section under the following heading:

To the changelog entry, please add a link to this PR (consider a more descriptive message):`

- Deprecate SentryBaseEvent#getOriginThrowable and add SentryBaseEvent#getThrowableMechanism(#1502)

If none of the above apply, you can opt out by adding _#skip-changelog_ to the PR description.

Generated by 🚫 dangerJS against ac506df

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SentryEvent.getThrowable() returns the unwrapped ExceptionMechanismException
3 participants