Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture markers in log4j2 and logback appenders #1551

Merged
merged 2 commits into from
Jun 23, 2021

Conversation

anderscarling
Copy link
Contributor

馃摐 Description

Collect markers from logger system in log4j2 and logback appenders.

馃挕 Motivation and Context

Adds useful context to logged errors, some more discussion in #1547

馃挌 How did you test it?

Running test suite for the relevant libraries.

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

The change should probably be documented on these pages:

Some inspiration could be had from this docs from the legacy sdk:

@marandaneto
Copy link
Contributor

@anderscarling thanks for doing this, please add an entry to the changelog

@anderscarling
Copy link
Contributor Author

@marandaneto Fixed that + the style issue (incorrect import order)

CHANGELOG.md Outdated Show resolved Hide resolved
@marandaneto
Copy link
Contributor

@marandaneto Fixed that + the style issue (incorrect import order)

awesome, thank you.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @anderscarling

@codecov-commenter
Copy link

Codecov Report

Merging #1551 (97eb5b8) into main (a5f30b4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1551      +/-   ##
============================================
+ Coverage     76.00%   76.01%   +0.01%     
- Complexity     1942     1944       +2     
============================================
  Files           192      192              
  Lines          6721     6725       +4     
  Branches        668      670       +2     
============================================
+ Hits           5108     5112       +4     
  Misses         1287     1287              
  Partials        326      326              
Impacted Files Coverage 螖
...src/main/java/io/sentry/log4j2/SentryAppender.java 85.54% <100.00%> (+0.35%) 猬嗭笍
...rc/main/java/io/sentry/logback/SentryAppender.java 89.02% <100.00%> (+0.27%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a5f30b4...97eb5b8. Read the comment docs.

@marandaneto marandaneto merged commit 1cdf98b into getsentry:main Jun 23, 2021
@anderscarling anderscarling deleted the capture-markers branch June 24, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants