Fix handling missing Spring Security on classpath on Java 8. #1552
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix handling missing Spring Security on classpath on Java 8.
💡 Motivation and Context
@ConditionalOnClass
placed on methods ends up with an exception when used with Java 8. This behavior does not exist with Java 11+.Fixes #1543
Fixes #1546
💚 How did you test it?
This bug is related with how classes are loaded, and the test with filtered class does not exactly reproduces the issue. To reproduce this issue we would need to add a separate Gradle module that has no Spring Security on the classpath. Not sure if it's worth it.
📝 Checklist