Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clock drift issue when calling DateUtils#getDateTimeWithMillisPrecision #1557

Merged
merged 5 commits into from
Jun 24, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Fix clock drift issue when calling DateUtils#getDateTimeWithMillisPrecision

💡 Motivation and Context

Fixes #1541

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review June 24, 2021 10:19
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2021

Codecov Report

Merging #1557 (734452d) into main (007cf3d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1557      +/-   ##
============================================
- Coverage     76.02%   76.01%   -0.01%     
+ Complexity     1953     1952       -1     
============================================
  Files           192      192              
  Lines          6760     6758       -2     
  Branches        676      675       -1     
============================================
- Hits           5139     5137       -2     
  Misses         1294     1294              
  Partials        327      327              
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/DateUtils.java 92.59% <100.00%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007cf3d...734452d. Read the comment docs.

@maciejwalkowiak maciejwalkowiak merged commit a233180 into main Jun 24, 2021
@maciejwalkowiak maciejwalkowiak deleted the gh-1541 branch June 24, 2021 11:54
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.
`Instructions and example for changelog`$

Please add an entry to CHANGELOG.md` to the "Unreleased" section under the following heading:

To the changelog entry, please add a link to this PR (consider a more descriptive message):`

- Fix clock drift issue when calling DateUtils#getDateTimeWithMillisPrecision(#1557)

If none of the above apply, you can opt out by adding _#skip-changelog_ to the PR description.

Generated by 🚫 dangerJS against 019df2d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clock drift issue when calling DateUtils#getDateTimeWithMillisPrecision
3 participants