Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add clearAttachments to Scope #1562

Merged
merged 3 commits into from
Jun 25, 2021

Conversation

xmanu
Copy link
Contributor

@xmanu xmanu commented Jun 25, 2021

馃摐 Description

We want to expose a method to clear the attachments on the scope.

馃挕 Motivation and Context

#1517

馃挌 How did you test it?

I added a test to ScopeTest to verify that the clearAttachments method really clears all attachments.

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

@marandaneto
Copy link
Contributor

@xmanu thanks a lot :)

CHANGELOG.md Outdated Show resolved Hide resolved
@philipphofmann philipphofmann changed the title Add clearAttachments to scope feat: Add clearAttachments to Scope Jun 25, 2021
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot.

@marandaneto marandaneto merged commit ceccb11 into getsentry:main Jun 25, 2021
@xmanu xmanu deleted the feat/clear-attachments branch June 25, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants