Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SentryAppender non-final for Log4j2 and Logback (#1602) #1603

Merged
merged 4 commits into from
Jul 16, 2021

Conversation

cocorossello
Copy link
Contributor

馃摐 Description

Make SentryAppender non-final for Log4j2 and Logback

馃挕 Motivation and Context

Users will be able to customize the appenders it if they need it. See #1602

馃挌 How did you test it?

Did a full build (I had to disable OutboxSenderTest class, deserialize sample envelope with event and two attachments test, SentryWebfluxIntegrationTest (due to an Error while closing the hub), but I believe those are not related to to my changes at all.

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

@marandaneto
Copy link
Contributor

thanks @cocorossello :)

CHANGELOG.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #1603 (983eb3f) into main (fb12011) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1603   +/-   ##
=========================================
  Coverage     76.07%   76.07%           
  Complexity     1976     1976           
=========================================
  Files           198      198           
  Lines          6842     6842           
  Branches        680      680           
=========================================
  Hits           5205     5205           
  Misses         1305     1305           
  Partials        332      332           
Impacted Files Coverage 螖
...src/main/java/io/sentry/log4j2/SentryAppender.java 85.54% <酶> (酶)
...rc/main/java/io/sentry/logback/SentryAppender.java 89.02% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update fb12011...983eb3f. Read the comment docs.

@marandaneto marandaneto merged commit 6d48e62 into getsentry:main Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants