Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind external properties to a dedicated class. #1750

Merged
merged 4 commits into from Oct 8, 2021
Merged

Conversation

maciejwalkowiak
Copy link
Contributor

馃摐 Description

Bind external properties to a dedicated ExternalOptions class.

馃挕 Motivation and Context

This allows to turn nullable Boolean fields from SentryOptions into a non-nullable boolean and keep simple getter and setter, without breaking Java beans standard.

Fixes #1738.

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

This allows to turn nullable `Boolean` fields from SentryOptions into a non-nullable `boolean` and keep simple getter and setter, without breaking Java beans standard.

Fixes #1738.
@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review October 4, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants