Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: PerformanceAndroidEventProcessor uses up to date isTracingEnabled set on Configuration callback #1786

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Fix: PerformanceAndroidEventProcessor uses up to date isTracingEnabled set on Configuration callback #1786

merged 2 commits into from
Oct 29, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 29, 2021 •
edited

📜 Description

Fix: PerformanceAndroidEventProcessor uses up to date isTracingEnabled set on Configuration callback

💡 Motivation and Context

Fixes #1785

💚 How did you test it?

tests are green already

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto merged commit c1044bb into main Oct 29, 2021
@marandaneto marandaneto deleted the fix/perf-android-event-processor branch October 29, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romtsn romtsn romtsn approved these changes

@maciejwalkowiak maciejwalkowiak Awaiting requested review from maciejwalkowiak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PerformanceAndroidEventProcessor does not work when set traces sample rate in OptionsConfiguration.configure()
2 participants
@marandaneto @romtsn