Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: ActivityFramesTracker does not throw if Activity has no observers #1799

Merged
merged 3 commits into from
Nov 11, 2021
Merged

Fix: ActivityFramesTracker does not throw if Activity has no observers #1799

merged 3 commits into from
Nov 11, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Nov 10, 2021 •
edited

馃摐 Description

Fix: ActivityFramesTracker does not throw if Activity has no observers

馃挕 Motivation and Context

Closes #1798

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

@marandaneto marandaneto merged commit d167f5a into main Nov 11, 2021
@marandaneto marandaneto deleted the fix/frames-tracker-no-observer branch November 11, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romtsn romtsn romtsn approved these changes

@maciejwalkowiak maciejwalkowiak Awaiting requested review from maciejwalkowiak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@marandaneto @romtsn