Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename: sentry-graphql #1801

Merged
merged 4 commits into from Nov 11, 2021
Merged

Rename: sentry-graphql #1801

merged 4 commits into from Nov 11, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Nov 11, 2021

馃摐 Description

Rename: sentry-graphql
#skip-changelog

馃挕 Motivation and Context

to keep the pattern with the other packages.

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

@marandaneto marandaneto changed the title rename sentry-graphql Rename: sentry-graphql Nov 11, 2021
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rename sentry-graphql-java.api to sentry-graphql.api as well?

@codecov-commenter
Copy link

Codecov Report

Merging #1801 (aece398) into main (e1c72cf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1801   +/-   ##
=========================================
  Coverage     75.74%   75.74%           
  Complexity     2194     2194           
=========================================
  Files           218      218           
  Lines          7804     7804           
  Branches        828      828           
=========================================
  Hits           5911     5911           
  Misses         1491     1491           
  Partials        402      402           
Impacted Files Coverage 螖
...try/graphql/SentryDataFetcherExceptionHandler.java 75.00% <酶> (酶)
.../java/io/sentry/graphql/SentryInstrumentation.java 73.68% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e1c72cf...aece398. Read the comment docs.

@marandaneto marandaneto merged commit 944fbbd into main Nov 11, 2021
@marandaneto marandaneto deleted the rename/sentry-graphql branch November 11, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants