Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify DateUtils with ISO8601Utils #1837

Merged
merged 10 commits into from Jan 18, 2022
Merged

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Dec 9, 2021

馃摐 Description

Replace usage of SimpleDateFormat with a helper class from GSON library.

Closes #1489

馃挕 Motivation and Context

It is faster and CG friendlier per their own documentation.

Closes #1489

馃挌 How did you test it?

Current unit tests for date helper class.

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

@denrase denrase self-assigned this Dec 9, 2021
@denrase denrase changed the title Feat/simplify dateutils Simplify DateUtils with ISO8601Utils Dec 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #1837 (a350b1d) into 6.x.x (79945ce) will decrease coverage by 0.08%.
The diff coverage is 77.12%.

Impacted file tree graph

@@             Coverage Diff              @@
##              6.x.x    #1837      +/-   ##
============================================
- Coverage     80.93%   80.85%   -0.09%     
- Complexity     2850     2878      +28     
============================================
  Files           207      208       +1     
  Lines         10475    10613     +138     
  Branches       1380     1411      +31     
============================================
+ Hits           8478     8581     +103     
- Misses         1510     1525      +15     
- Partials        487      507      +20     
Impacted Files Coverage 螖
...y/vendor/gson/internal/bind/util/ISO8601Utils.java 76.82% <76.82%> (酶)
sentry/src/main/java/io/sentry/DateUtils.java 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 79945ce...a350b1d. Read the comment docs.

@denrase denrase marked this pull request as ready for review December 9, 2021 16:22
@bruno-garcia
Copy link
Member

Just missing a change log, otherwise, :shipit:

@marandaneto
Copy link
Contributor

I've fixed the javadocs issues and sharing the TIMEZONE_UTC field from the Util class

@marandaneto marandaneto added this to In progress in kanban Jan 18, 2022
@marandaneto marandaneto merged commit 49003d3 into 6.x.x Jan 18, 2022
kanban automation moved this from In progress to Done Jan 18, 2022
@marandaneto marandaneto deleted the feat/simplify-dateutils branch January 18, 2022 13:05
@github-actions
Copy link
Contributor

Fails
馃毇 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Simplify DateUtils with ISO8601Utils ([#1837](https://github.com/getsentry/sentry-java/pull/1837))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 馃毇 dangerJS against 6d51f52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants