Fix: Detect App Cold start correctly for Hybrid SDKs #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
changed the title
romtsn
approved these changes
Dec 20, 2021
| @@ -18,7 +18,7 @@ | |||
| private @Nullable Long appStartEndMillis; | |||
|
|
|||
| /** The type of App start coldStart=true -> Cold start, coldStart=false -> Warm start */ | |||
| private boolean coldStart; | |||
| private @Nullable Boolean coldStart = null; | |||
There was a problem hiding this comment.
we kinda have 3 states now for this: unset, cold, warm - should we introduce an enum rather?
There was a problem hiding this comment.
yep, enum is more expensive but it makes sense, since this is internal, I will make it in another PR to unblock this one and cut a release
Codecov Report
@@ Coverage Diff @@
## main #1855 +/- ##
=========================================
Coverage 75.51% 75.51%
Complexity 2239 2239
=========================================
Files 225 225
Lines 8001 8001
Branches 846 846
=========================================
Hits 6042 6042
Misses 1549 1549
Partials 410 410 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摐 Description
Fix: Detect App Cold start correctly for Hybrid SDKs
馃挕 Motivation and Context
getsentry/sentry-react-native#1968
馃挌 How did you test it?
馃摑 Checklist
馃敭 Next steps