Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Change scope of servlet-api to compileOnly. #1880

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Fix: Change scope of servlet-api to compileOnly. #1880

merged 2 commits into from
Jan 21, 2022

Conversation

maciejwalkowiak
Copy link
Contributor

馃摐 Description

Change scope of servlet-api to compileOnly.

馃挕 Motivation and Context

servlet-api should be a compile dependency, users should include servlet-api independently or the application server application runs on provides this dependency in runtime.

Fixes #1878

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@codecov-commenter
Copy link

Codecov Report

Merging #1880 (4f7ba1b) into main (01cda06) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1880   +/-   ##
=========================================
  Coverage     75.51%   75.51%           
  Complexity     2239     2239           
=========================================
  Files           225      225           
  Lines          8001     8001           
  Branches        846      846           
=========================================
  Hits           6042     6042           
  Misses         1549     1549           
  Partials        410      410           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 01cda06...4f7ba1b. Read the comment docs.

@marandaneto marandaneto merged commit f95ad4e into main Jan 21, 2022
@marandaneto marandaneto deleted the gh-1878 branch January 21, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry Servlet using Servlet API as Runtime Dependency
3 participants