Fix NPE while adding "response_body_size" breadcrumb #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neseleznev
requested review from
maciejwalkowiak,
marandaneto and
romtsn
as code owners
When response body is null, set size to 0 in a same fashion "request_body_size" is set. Add test. Add note to the changelog
|
Fixed the code style with force push |
marandaneto
reviewed
Jan 25, 2022
|
thanks for doing that @neseleznev |
still fails, run |
romtsn
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When response body is null, set size to 0
in a same fashion "request_body_size" is set.
Add test.
Add note to the changelog
Closes #1883 , see description there
馃挌 How did you test it?
I wrote a test.
Had no time to build the project and run the tests locally, TBH
馃摑 Checklist