Feat: Enable enableScopeSync by default for Android #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
reviewed
Mar 2, 2022
| @@ -249,7 +249,10 @@ | |||
| /** list of scope observers */ | |||
| private final @NotNull List<IScopeObserver> observers = new ArrayList<>(); | |||
|
|
|||
| /** Enable the Java to NDK Scope sync */ | |||
| /** | |||
| * Enable the Java to NDK Scope sync. The default value for sentry-java is disabled and enabled | |||
There was a problem hiding this comment.
Suggested change
| * Enable the Java to NDK Scope sync. The default value for sentry-java is disabled and enabled | |
| * Enable the Java to Native Scope sync. The default value for sentry-java is disabled and enabled |
I think NDK is something Android-specific and these are general Java options?
There was a problem hiding this comment.
Right now we only support NDK anyway, Its fine IMO.
romtsn
approved these changes
Mar 2, 2022
bruno-garcia
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摐 Description
Feat: Enable enableScopeSync by default for Android
馃挕 Motivation and Context
Closes #1914
馃挌 How did you test it?
馃摑 Checklist
馃敭 Next steps