Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC radiography integration #1998

Closed
wants to merge 1 commit into from
Closed

PoC radiography integration #1998

wants to merge 1 commit into from

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Apr 20, 2022

#skip-changelog

That's just a PoC of radiography as an attachment.
Ideally Sentry UI would render that nicely.

It should be a separate package since it needs to add the com.squareup.radiography:radiography dependency.
We can check at runtime if it's available in the classpath and add the integration automatically.
The package should also be installed automatically with the SAGP if radiography is in the classpath.
Support for Jetpack compose depends on androidx.compose.ui:ui-tooling in the classpath, that can also be added automatic if compose is in the classpath.

Closes #1647

@codecov-commenter
Copy link

Codecov Report

Merging #1998 (067e596) into 6.x.x (bd2a665) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              6.x.x    #1998   +/-   ##
=========================================
  Coverage     80.71%   80.71%           
  Complexity     3039     3039           
=========================================
  Files           217      217           
  Lines         11226    11226           
  Branches       1503     1503           
=========================================
  Hits           9061     9061           
  Misses         1600     1600           
  Partials        565      565           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd2a665...067e596. Read the comment docs.

@marandaneto
Copy link
Contributor Author

radiography

That's what it'd look like.

@marandaneto
Copy link
Contributor Author

Ideally, the file format would match with the radiography on iOS, so Sentry UI could prettify and offer features like collapsing, etc...

Base automatically changed from 6.x.x to main June 7, 2022 10:10
@romtsn
Copy link
Member

romtsn commented Jan 3, 2023

Closing in favour of #2440

@romtsn romtsn closed this Jan 3, 2023
@romtsn romtsn deleted the feat/poc-radiography branch July 19, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Radiography integration
3 participants