Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Android native SDK name override #2035

Merged
merged 1 commit into from May 10, 2022
Merged

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented May 10, 2022

馃摐 Description

馃挕 Motivation and Context

Enables integrations, e.g. sentry-unity SDK, to override the native SDK name reported in errors

馃挌 How did you test it?

not sure how to test this except manually - are there some integration tests already that this could be included in?

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes
  • depends on Bump/native 0.4.17聽#2033 to actually make a difference

@vaind vaind changed the base branch from main to 6.x.x May 10, 2022 16:55
@vaind vaind force-pushed the feat/android-sdk-name-override branch from 1e35d42 to cad950e Compare May 10, 2022 17:05
@vaind vaind marked this pull request as ready for review May 10, 2022 17:09
@romtsn
Copy link
Member

romtsn commented May 10, 2022

Hm, sorry if I missed something, but aren't these lines doing exactly that already?

https://github.com/getsentry/sentry-native/blob/bd56100922e1359c08f512e84ab975972788dc98/include/sentry.h#L26-L32

@vaind
Copy link
Collaborator Author

vaind commented May 10, 2022

Hm, sorry if I missed something, but aren't these lines doing exactly that already?

https://github.com/getsentry/sentry-native/blob/bd56100922e1359c08f512e84ab975972788dc98/include/sentry.h#L26-L32

Yes, that's the automatic behaviour. This PR enables integrating SDKs to set e.g. sentry.android.native.unity

@romtsn
Copy link
Member

romtsn commented May 10, 2022

Ah ok, this makes sense 馃憤

@vaind vaind merged commit 66140be into 6.x.x May 10, 2022
@vaind vaind deleted the feat/android-sdk-name-override branch May 10, 2022 19:21
@github-actions
Copy link
Contributor

Fails
馃毇 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Android native SDK name override ([#2035](https://github.com/getsentry/sentry-java/pull/2035))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 馃毇 dangerJS against cad950e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants