Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling Sentry.init and specifying contextTags now has an effect on the jul SentryAppender #2057

Merged
merged 7 commits into from May 25, 2022

Conversation

adinauer
Copy link
Member

📜 Description

No longer used the options property in SentryAppender, instead get Options from HubAdapter.

💡 Motivation and Context

Fix #2043 for jul

💚 How did you test it?

Demo Code

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@maciejwalkowiak
Copy link
Contributor

Similar to #2054, I believe it should be put on hold until #2052 (review) is resolved, so that we have ideally one consistent approach between logging frameworks.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (6.x.x@e0fd191). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             6.x.x    #2057   +/-   ##
========================================
  Coverage         ?   81.07%           
  Complexity       ?     3217           
========================================
  Files            ?      230           
  Lines            ?    11821           
  Branches         ?     1572           
========================================
  Hits             ?     9584           
  Misses           ?     1650           
  Partials         ?      587           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0fd191...4aa1a41. Read the comment docs.

@adinauer adinauer merged commit f57d435 into 6.x.x May 25, 2022
@adinauer adinauer deleted the fix/init-not-affecting-jul branch May 25, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants