SentryOptions#merge is now public and can be used to load ExternalOptions #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
changed the title
maciejwalkowiak
approved these changes
Jun 10, 2022
adinauer
commented
Jun 13, 2022
| @@ -1710,7 +1710,7 @@ private SentryOptions(final boolean empty) { | |||
| * | |||
| * @param options options loaded from external locations | |||
| */ | |||
| void merge(final @NotNull ExternalOptions options) { | |||
| public void merge(final @NotNull ExternalOptions options) { | |||
There was a problem hiding this comment.
@marandaneto do you see any harm in making this public?
There was a problem hiding this comment.
If there's a use case on the logging integrations, I'm fine with it, this is not used on Android, so your call.
marandaneto
reviewed
Jun 13, 2022
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
adinauer
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2088 +/- ##
=========================================
Coverage 81.11% 81.11%
Complexity 3232 3232
=========================================
Files 230 230
Lines 11850 11850
Branches 1572 1572
=========================================
Hits 9612 9612
Misses 1652 1652
Partials 586 586
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摐 Description
Allows developers to deserialize
ExternalOptionsand then merge them intoSentryOptions.馃挕 Motivation and Context
Closes #2086
馃挌 How did you test it?
馃摑 Checklist
馃敭 Next steps